-
Notifications
You must be signed in to change notification settings - Fork 96
Addition of Stats Exporter for Microsoft Azure #795
Addition of Stats Exporter for Microsoft Azure #795
Conversation
Started by adding a few basic options that can be configured. Added a timer to handle batching of metric exports.
Started integration of App Insights SDK.
… up through other exporter files
For now, I have manually verified the CLA. |
Please fix the build and unresolved comments. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 148 148
Lines 10743 10743
Branches 798 798
=======================================
Hits 10252 10252
Misses 491 491 Continue to review full report at Codecov.
|
I went ahead and resolved comments that were a simple fix (adding license header, version bump, etc). Left two open that were related to design and testing. Happy to address any other concerns! Thanks. |
@googlebot I signed it |
@mayurkale22 Thanks for the approve-The only CLA bump here is Gaven, but it's from an account I don't think he has access to (since it was with his university account and he's graduated). @gdkerr is Gaven Kerr's other account; I think you can probably just manually set the CLA as signed for him, or reach out to him to confirm. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
I have manually verified the CLA and merged the PR. Let me know if you are waiting for the release. |
Great news thanks! We'd like to pick up this release but it's not urgent (order of weeks would be our integration time) |
@mayurkale22 I'm just curious if you have a timeline for package release including this exporter? We have some resources that I would love to assign to integrate this coming soon. |
Apologies for the delay. I have cut the new release. See: https://www.npmjs.com/package/@opencensus/exporter-azure Noticed two things:
|
No need to apologize, this is great! Thank you! |
This is in relation to issue #751 which I opened for my team's senior design project at NC State University.