Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to summaries #68

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Improvements to summaries #68

merged 7 commits into from
Sep 12, 2024

Conversation

CodyCBakerPhD
Copy link
Member

@CodyCBakerPhD CodyCBakerPhD commented Sep 12, 2024

  • Remove index column on all summaries
  • Fix by-day aggregation for previous summaries
  • Add dandiset-wide summaries
  • Add summary by asset path (for versions and dandisets)
  • Add summary by region (for versions and dandisets)
  • Services (AWS/GCP) now include sugregions
  • CIDR requests are now cached in memory to avoid sending repeated requests
  • Test cases now include AWS and GCP example IPs (at least as of summer 2024)

@CodyCBakerPhD CodyCBakerPhD linked an issue Sep 12, 2024 that may be closed by this pull request
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review September 12, 2024 20:35
@CodyCBakerPhD CodyCBakerPhD merged commit b59ae1d into main Sep 12, 2024
2 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the final_fixes branch September 12, 2024 20:35
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 91.42857% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.12%. Comparing base (b739f3f) to head (23290f8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/dandi_s3_log_parser/_ip_utils.py 77.50% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   64.79%   71.12%   +6.32%     
==========================================
  Files          14       14              
  Lines         588      658      +70     
==========================================
+ Hits          381      468      +87     
+ Misses        207      190      -17     
Flag Coverage Δ
unittests 71.12% <91.42%> (+6.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g_parser/_bin_all_reduced_s3_logs_by_object_key.py 84.44% <ø> (ø)
.../dandi_s3_log_parser/_dandi_s3_log_file_reducer.py 80.95% <ø> (ø)
..._s3_log_parser/_map_binned_s3_logs_to_dandisets.py 97.56% <100.00%> (+4.31%) ⬆️
src/dandi_s3_log_parser/_ip_utils.py 80.00% <77.50%> (+25.94%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant