Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set scheme for traefik_route #234

Merged
merged 6 commits into from
Sep 5, 2023
Merged

Set scheme for traefik_route #234

merged 6 commits into from
Sep 5, 2023

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Sep 1, 2023 •
edited
Loading

Issue

Grafana, which uses traefik_route, is currently unable to tell if the ingress endpoint is http or https.

Solution

This PR adds a scheme arg, so that traefik could inform over relation data which scheme it is using.

In tandem with:

Drive-by fixes:

Testing Instructions

Release Notes

Set scheme for traefik_route.

@sed-i sed-i mentioned this pull request Sep 1, 2023
Merged
@sed-i sed-i marked this pull request as ready for review September 5, 2023 16:47
@sed-i sed-i mentioned this pull request Sep 5, 2023
Merged
sed-i
sed-i commented Sep 5, 2023
View reviewed changes
tox.ini Show resolved Hide resolved
@sed-i sed-i mentioned this pull request Sep 5, 2023
Open
@sed-i sed-i merged commit 36d87d4 into main Sep 5, 2023
14 checks passed
@sed-i sed-i deleted the feature/set_trfk_route_scheme branch September 5, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abuelodelanada Abuelodelanada Abuelodelanada approved these changes

@lucabello lucabello Awaiting requested review from lucabello

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti

@dstathis dstathis Awaiting requested review from dstathis

@simskij simskij Awaiting requested review from simskij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sed-i @Abuelodelanada