Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy support #14

Closed
wants to merge 4 commits into from
Closed

Add proxy support #14

wants to merge 4 commits into from

Conversation

arturo-seijas
Copy link
Collaborator

Load proxy configuration from the juju model env vars

@arturo-seijas arturo-seijas requested a review from a team as a code owner July 21, 2023 12:12
@arturo-seijas arturo-seijas mentioned this pull request Jul 26, 2023
Merged
yanksyoon
yanksyoon approved these changes Jul 26, 2023
View reviewed changes
Copy link

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestions!

tests/unit/test_charm_state.py
Comment on lines +75 to 78
CharmState.from_charm(charm)
assert False
except CharmConfigInvalidError:
assert True
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better with with pytest.raises?

@github-actions
Copy link
Contributor

Lint checks failed for b412c8f

```

--- /home/ubuntu/github-runner/_work/saml-integrator-operator/saml-integrator-operator/tests/unit/test_charm.py:before 2023-07-26 08:08:48.909065
+++ /home/ubuntu/github-runner/_work/saml-integrator-operator/saml-integrator-operator/tests/unit/test_charm.py:after 2023-07-26 08:09:27.209400
@@ -11,7 +11,6 @@
from ops.testing import Harness

from charm import SamlIntegratorOperatorCharm

PROXY_SETTINGS = {
"JUJU_CHARM_HTTP_PROXY": "http://proxy.example:3128",

@github-actions
Copy link
Contributor

Test coverage for b412c8f

Name                 Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------
src/charm.py            51      1     10      1    97%   57
src/charm_state.py      45      0      6      0   100%
src/saml.py             45      0      8      0   100%
----------------------------------------------------------------
TOTAL                  141      1     24      1    99%

Static code analysis report

Run started:2023-07-26 08:09:38.170232

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 703
  Total lines skipped (#nosec): 4
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@jdkandersson
Copy link
Collaborator

Is this still needed?

@arturo-seijas
Copy link
Collaborator Author

Is this still needed?

No, juju will atuomatically inject configuration files for apt and this is the only use case for the proxy configuration in this charm

@arturo-seijas arturo-seijas deleted the proxy-support branch July 27, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiiwang01 weiiwang01 weiiwang01 left review comments

@yanksyoon yanksyoon yanksyoon approved these changes

@amandahla amandahla Awaiting requested review from amandahla

@jdkandersson jdkandersson Awaiting requested review from jdkandersson

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arturo-seijas @jdkandersson @amandahla @weiiwang01 @yanksyoon