-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy support #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor suggestions!
CharmState.from_charm(charm) | ||
assert False | ||
except CharmConfigInvalidError: | ||
assert True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be better with with pytest.raises
?
Lint checks failed for b412c8f
--- /home/ubuntu/github-runner/_work/saml-integrator-operator/saml-integrator-operator/tests/unit/test_charm.py:before 2023-07-26 08:08:48.909065 from charm import SamlIntegratorOperatorCharmPROXY_SETTINGS = {
|
Test coverage for b412c8f
Static code analysis report
|
Is this still needed? |
No, juju will atuomatically inject configuration files for apt and this is the only use case for the proxy configuration in this charm |
Load proxy configuration from the juju model env vars