-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: JLink plugin #688
base: main
Are you sure you want to change the base?
feat: JLink plugin #688
Conversation
Add initial implementation of jlink plugin. It creates Java runtime for a built project. If no jar files are found it generates an image for java.base module.
Co-authored-by: Alex Lowe <[email protected]>
Added PR for the linkcheck linter failure: #700 |
Thanks!!! I have added one. |
This step is not necessary as the required file is deployed by jlink.
Use format strings to clean up code.
I discussed this with my team this week, and the conclusion was that the way we should do this is as an option for the base Java plugin. So the default behaviour would be the current behaviour (which I think is to not stage a JRE?), but the jlink options here would be changed to |
Hmm, so we will have to enumerate plugin properties in java plugin and retrieve ones with Also we need ability to decouple build and stage Java. |
This PR adds jlink plugin that allows to generate Java runtime tailored for the Java application.
When ran without supplying jar file property it will search the staging area for any jars and generate an image for them.
If no jar files are found, then java.base image will be generated.
This PR includes unit and integration tests.
The plugin documentation is split into separate PR: #689
Sample ROCK using plugin: https://github.com/canonical/openjdk-rocks/tree/prototype/demos/java-runtime