Integrate with Starbase

[syu-w]

No description provided.

[codecov]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

[cmatsuoka]

This is a very large changeset and difficult to examine in detail. It seems that the majority of changes are auto-generated so I just did a quick pass on those. I didn't find obvious red flags so if this is passing tests it's probably ok, and existing issues can be dealt with in follow-ups. It's a good idea however to check the comments and address them if applicable.

[cmatsuoka]

Ir seems that this can imported only if TYPE_CHECKING?

[syu-w]

I got:

rockcraft/services/lifecycle.py:35:29: TCH004 Move import `craft_parts.LifecycleManager` out of type-checking block. Import is used for more than type hinting.

[cmatsuoka]

I'm a bit confused here, how the starbase migration affected this test?

[syu-w]

The shebang for that python file got changed to a sh that exec with extra environment and parameters. I assume tox did this.

[tigarmo]

This one is definitely a problem: the #!/bin/python3 shebang should be set by the Python plugin and the purpose of the test is to verify this. #!/bin/sh is not an acceptable value, we need to look into this more

[syu-w]

#!/bin/sh
'''exec' /run/user/1000/tox_tmp/integration-py3.10/pytest-of-ubuntu/pytest-0/test_python_plugin_ubuntu_ubun1/parts/my-part/install/bin/python3 "$0" "$@"
' '''
# -*- coding: utf-8 -*-
import re
import sys
from hello.__main__ import main
if __name__ == '__main__':
    sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])
    sys.exit(main())

The file become like this if run under tox.

[tigarmo]

Right I understand that, but we have to figure out a way around that because as it is the test is not checking what it should be checking

[syu-w]

I don't see any configuration can disable that. We may have to get a separate test for it without run in tox.

[syu-w]

Well, I can create a spread test for that, but it is not possible to do in tox.

[syu-w]

Added

[tigarmo]

I don't know if I agree with moving the frozen requirements here. The problem is that this ties Rockcraft to transitive dependencies forever, even if we don't need them anymore, because the application needs to freeze all of its requirements.
What was the reasoning to remove the requirements-*.txt files?

[tigarmo]

This one is definitely a problem: the #!/bin/python3 shebang should be set by the Python plugin and the purpose of the test is to verify this. #!/bin/sh is not an acceptable value, we need to look into this more