feat: Add cloud version string #413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-dubs
requested changes
Sep 10, 2024
| @@ -112,6 +112,8 @@ def test_public_api(cloud: BaseCloud): | |||
| # Not sure there's a great way to test this other than not raising | |||
| cloud.image_serial(image_id) | |||
|
|
|||
| version = cloud.version() | |||
| assert isinstance(version, str) or version is None | |||
There was a problem hiding this comment.
Suggested change
| assert isinstance(version, str) or version is None | |
| assert isinstance(version, str) or version is None |
blackboxsw
reviewed
Sep 11, 2024
| @@ -260,6 +260,10 @@ def use_key(self, public_key_path, private_key_path=None, name=None): | |||
| self._log.debug("using SSH key from %s", public_key_path) | |||
| self.key_pair = KeyPair(public_key_path, private_key_path, name) | |||
|
|
|||
| def version(self) -> Optional[str]: | |||
| """Version string of the platform.""" | |||
| return None | |||
There was a problem hiding this comment.
Is there a lot of value in us returning None here instead of just an empty string ""? We can then avoid the Optional[str] handling for typing validation.
There was a problem hiding this comment.
I agree with chad. I don't think there is much benefit to returning a None instead of a falsey/empty string.
blackboxsw
reviewed
Sep 25, 2024
| @@ -660,3 +660,12 @@ def clean(self) -> List[Exception]: | |||
| exceptions.append(e) | |||
|
|
|||
| return exceptions | |||
|
|
|||
| def version(self): | |||
There was a problem hiding this comment.
@holmanb We should probably lru_cache this as it's unlikely to change mid integration test run, but it's something we don't want to recalculate any time we call it.
blackboxsw
reviewed
Sep 25, 2024
| @@ -437,6 +437,10 @@ def clean(self) -> List[Exception]: | |||
| exceptions.append(e) | |||
| return exceptions | |||
|
|
|||
| def version(self): | |||
There was a problem hiding this comment.
Same, I'd cache this value somehow as it's unlikely to change on the host mid-test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.