feat(oracle): only allow public subnets to be selected from target VCN #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-dubs
force-pushed
the
oracle-only-use-public-subnets
branch
4 times, most recently
from
095aadb
to
e5394f1
Compare
a-dubs
force-pushed
the
oracle-only-use-public-subnets
branch
from
e5394f1
to
3d84b7b
Compare
aciba90
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(oracle): only allow public subnets to be selected from target VCN
The OCI VCN creation wizard creates both a public and a private subnet and if the private subnet ends up being the first subnet, then this would cause all CTF tests using this VCN to hang up and fail because pycloudlib blindly chooses the first subnet.
Now, private subnets will be skipped/ignored, and the first public subnet will be selected.