Oracle allow explicitly specifying vcn for subnet selection #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-dubs
changed the title
a-dubs
changed the title
a-dubs
force-pushed
the
oracle-allow-specifying-vcn
branch
3 times, most recently
from
fb1e3ee
to
c603b58
Compare
CalvoM
reviewed
Aug 16, 2023
holmanb
reviewed
Aug 16, 2023
pycloudlib/oci/utils.py
Outdated
| @@ -47,13 +48,27 @@ def get_subnet_id( | |||
| network_client: Instance of VirtualNetworkClient. | |||
| compartment_id: Compartment where the subnet has to belong | |||
| availability_domain: Domain to look for subnet id in. | |||
| target_subnet_name: Name of the subnet to look for. | |||
a-dubs
force-pushed
the
oracle-allow-specifying-vcn
branch
from
c603b58
to
692bbbe
Compare
CalvoM
approved these changes
Aug 18, 2023
aciba90
requested changes
Aug 24, 2023
Oracle's pycloudlib implementation currently uses the most recently created VCN (Virtual Cloud Network) in the given compartment for new VM instances being created. Problems can therefore arise if a newly created VCN uses a subnet with different rules than the previously used VCN's subnet. Now, instead of relying on just blindly choosing the most recently created VCN, pycloudlib supports specifying a vcn_name value which it will use to find a VCN that has a name that exactly matches the given vcn_name.
a-dubs
force-pushed
the
oracle-allow-specifying-vcn
branch
from
692bbbe
to
461cbee
Compare
|
Jira ticket for context: https://warthogs.atlassian.net/browse/CPC-2908 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(oracle): ability to specify vcn by name for subnet selection
Oracle's pycloudlib implementation currently uses the most recently created VCN (Virtual Cloud Network) in the given compartment for new VM instances being created. Problems can therefore arise if a newly created VCN uses a subnet with different rules than the previously used VCN's subnet.
Now, instead of relying on just blindly choosing the most recently created VCN, pycloudlib supports specifying a vcn_name value which it will use to find a VCN that has a name that exactly matches the given vcn_name.