Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discourse-gatekeeper] Migrate charm docs #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request was autogenerated by discourse-gatekeeper to migrate existing documentation from server to the git repository.

…w: docs/Explanation/roadmap.md,docs/how-to/secure-an-ingress-with-tls.md // removed: docs/how-to/add-the-nginx-route-relation.md
@github-actions github-actions bot requested a review from a team as a code owner December 14, 2023 17:00
@@ -0,0 +1,65 @@
# How to secure an Ingress with TLS.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ingress shouldn't be capitalized

@@ -40,7 +37,7 @@ Now let's deploy the charm just to confirm everything is working as expected wit
```
charmcraft pack
```
This will build the charm inside an LXC container for you. The output will tell you the location of the built charm. For example, `my-charm_ubuntu-22.04-amd64.charm`.
This will build the charm inside an LXC for you. The output will tell you the location of the built charm. In my case, that was `my-charm_ubuntu-22.04-amd64.charm`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the previous statement was better. So maybe revert this change?

@@ -0,0 +1,5 @@
Below is the roadmap for the Nginx Ingress Integrator Operator.

## October 2022 to April 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be Oct 2023- April 2024?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant