Fix redirects #247
Open
Fix redirects #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
Saviq
reviewed
Jun 13, 2024
redirects.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| /doc?: https://canonical-mir.readthedocs-hosted.com/stable/ | |||
| /doc/index.html?: https://canonical-mir.readthedocs-hosted.com/stable/ | |||
| /doc/cppguide?: https://canonical-mir.readthedocs-hosted.com/stable/_static/cppguide/ | |||
| /doc/cppguide/?: https://canonical-mir.readthedocs-hosted.com/stable/_static/cppguide/ | |||
There was a problem hiding this comment.
This isn't the right change, we still need anyone landing at /doc/cppguide to redirect, regardless of trailing slash… and anyway it doesn't work…
|
@Saviq should be working now. Are you able to approve? |
|
@carkod now the no- |
Saviq
approved these changes
Jun 17, 2024
Yes, I think I could try to handle it in a single line with wildcards, but I think it's better to be as explicit as possible, we've had obscure issues on u.com when using wildcards. This way we can also track of changes, which will make it eaier if want to change things in the future or revert it back. |
jmuzina
approved these changes
Jun 17, 2024
jmuzina
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
https://mir-server.io/doc/cppguide/index.html # 404 (actually says 400: Not found in <title>)
https://mir-server.io/doc/getting_involved_in_mir.html # 200
QA
https://mir-server-io-247.demos.haus/doc/cppguide/index.html should not 404 but redirect to https://canonical-mir.readthedocs-hosted.com/stable/_static/cppguide/
https://mir-server-io-247.demos.haus/doc/cppguide/ should redirect to https://canonical-mir.readthedocs-hosted.com/stable/_static/cppguide/
https://mir-server-io-247.demos.haus/doc/getting_involved_in_mir.html should redirect to the new docs site