Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirects #247

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix redirects #247

wants to merge 1 commit into from

Conversation

@webteam-app
Copy link
Collaborator

redirects.yaml Outdated
@@ -1,6 +1,6 @@
/doc?: https://canonical-mir.readthedocs-hosted.com/stable/
/doc/index.html?: https://canonical-mir.readthedocs-hosted.com/stable/
/doc/cppguide?: https://canonical-mir.readthedocs-hosted.com/stable/_static/cppguide/
/doc/cppguide/?: https://canonical-mir.readthedocs-hosted.com/stable/_static/cppguide/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the right change, we still need anyone landing at /doc/cppguide to redirect, regardless of trailing slash… and anyway it doesn't work…

@carkod
Copy link
Contributor Author

carkod commented Jun 17, 2024

@Saviq should be working now. Are you able to approve?

@Saviq
Copy link
Contributor

Saviq commented Jun 17, 2024

@carkod now the no-index.html variant doesn't work…

https://mir-server-io-247.demos.haus/doc/cppguide

Copy link
Contributor

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame this can't be handled by a single line, but OK!

@carkod
Copy link
Contributor Author

carkod commented Jun 17, 2024

Shame this can't be handled by a single line, but OK!

Yes, I think I could try to handle it in a single line with wildcards, but I think it's better to be as explicit as possible, we've had obscure issues on u.com when using wildcards.

This way we can also track of changes, which will make it eaier if want to change things in the future or revert it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants