feat: run apt upgrade in overlay #875
Open
+95
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linostar
force-pushed
the
ROCKS-1520/apt-upgrade-for-overlay
branch
from
09e2b70
to
4b30fd5
Compare
|
@canonical/starcraft-reviewers |
tigarmo
reviewed
Oct 11, 2024
| @@ -99,6 +99,8 @@ def prologue(self) -> None: | |||
| self._project_info.overlay_mount_dir, self._project_info | |||
| ) | |||
| ctx.refresh_packages_list() | |||
| logger.info("Upgrading packages in the overlay base") | |||
| ctx.upgrade_packages() | |||
There was a problem hiding this comment.
@linostar have you tested this with Rockcraft? I'm don't remember the details but I'm almost sure that the contents of this PackageCacheMount layer do not end up in the final lifecycle payload. Typically we update the packages list and then mount a layer on top of this one to install overlay-packages and execute the overlay-script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
apt-get upgradein overlay once. This is for both Pro and non-Pro rocks.The object is to make the overlay base a Pro overlay base by upgrading all packages there.