Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run apt upgrade in overlay #875

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

linostar
Copy link
Contributor

@linostar linostar commented Oct 9, 2024

  • Have you signed the CLA?

Run apt-get upgrade in overlay once. This is for both Pro and non-Pro rocks.
The object is to make the overlay base a Pro overlay base by upgrading all packages there.

@linostar linostar force-pushed the ROCKS-1520/apt-upgrade-for-overlay branch from 09e2b70 to 4b30fd5 Compare October 9, 2024 16:28
@linostar linostar marked this pull request as ready for review October 11, 2024 08:52
@linostar
Copy link
Contributor Author

@canonical/starcraft-reviewers

@@ -99,6 +99,8 @@ def prologue(self) -> None:
self._project_info.overlay_mount_dir, self._project_info
)
ctx.refresh_packages_list()
logger.info("Upgrading packages in the overlay base")
ctx.upgrade_packages()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linostar have you tested this with Rockcraft? I'm don't remember the details but I'm almost sure that the contents of this PackageCacheMount layer do not end up in the final lifecycle payload. Typically we update the packages list and then mount a layer on top of this one to install overlay-packages and execute the overlay-script.

@tigarmo tigarmo requested review from mr-cal and removed request for lengau October 11, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants