Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(part_handler): fetch correct target stage packages #721

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dilyn-corner
Copy link

  • Have you signed the CLA?

This is a partial attempt at fixing canonical/snapcraft#4542 specifically Alex's comment.

Note that this change does not take into consideration cases where the stage package is only available for architecture: all.

This eliminates the need to specify "${CRAFT_ARCH_BUILD_FOR}" for stage
packages.

Signed-off-by: Dilyn Corner <[email protected]>
@lengau
Copy link
Contributor

lengau commented Apr 26, 2024

Adding @mr-cal specifically since he probably has context on what else we need to do to fix this before we merge. (See: #258)

@lengau lengau requested a review from mr-cal April 26, 2024 17:37
@lengau
Copy link
Contributor

lengau commented Apr 26, 2024

We'll need to ensure we test for regressions against LP #1983009 before merging

Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in a call with @dilyn-corner a few weeks ago and in a few chats, I have two concerns here:

  1. We need a design that does not change this behavior for existing applications. For example, we don't want the behavior for core22 snaps to change.
  2. We retracted this change when core22 was getting released. @cmatsuoka was working with someone in Canonical who maintains the archives on an issue where dpkg --add-architecture would be misinformed by the archives that packages were available for an architecture when they were not. I don't believe that issue was solved. We will need to thoroughly test staging packages inside the same architecture families (stage armhf in an arm64 build environment) and across families (e.g. stage a riscv64 package in an amd64 build environment).

@mr-cal
Copy link
Contributor

mr-cal commented Jul 29, 2024

Related: canonical/craft-archives#104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants