fix(part_handler): fetch correct target stage packages #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dilyn Corner <[email protected]>
This eliminates the need to specify "${CRAFT_ARCH_BUILD_FOR}" for stage
packages.
Signed-off-by: Dilyn Corner <[email protected]>
lengau
approved these changes
Apr 26, 2024
|
We'll need to ensure we test for regressions against LP #1983009 before merging |
mr-cal
reviewed
Jul 18, 2024
There was a problem hiding this comment.
As discussed in a call with @dilyn-corner a few weeks ago and in a few chats, I have two concerns here:
- We need a design that does not change this behavior for existing applications. For example, we don't want the behavior for core22 snaps to change.
- We retracted this change when core22 was getting released. @cmatsuoka was working with someone in Canonical who maintains the archives on an issue where
dpkg --add-architecturewould be misinformed by the archives that packages were available for an architecture when they were not. I don't believe that issue was solved. We will need to thoroughly test staging packages inside the same architecture families (stagearmhfin anarm64build environment) and across families (e.g. stage ariscv64package in anamd64build environment).
|
Related: canonical/craft-archives#104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial attempt at fixing canonical/snapcraft#4542 specifically Alex's comment.
Note that this change does not take into consideration cases where the stage package is only available for
architecture: all.