Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vultr): add override for network interface detection #5847

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andy191x
Copy link

@andy191x andy191x commented Oct 30, 2024

Proposed Commit Message

feat(vultr): add override for network interface detection (#5847)

Additional Context

The purpose of this feature is to provide the Vultr team with a way to define custom NIC lists to scan for metadata. This is particularly useful when dealing with niche hardware deployments.

The feature checks for the presence of an /opt/vultr/find_candidate_nics.sh shell script on the running guest image. If detected, DataSourceVultr uses that as an optional source of truth before falling back to net.find_candidate_nics().

Test Steps

This feature was tested manually on Vultr's Ubuntu 22.04 and Ubuntu 24.04 images (as of 10/2024).

The added functionality is low risk, as it is both opt-in and limited to the Vultr cloud.

cp vultr.py /usr/lib/python3/dist-packages/cloudinit/sources/helpers/vultr.py
cloud-init clean -r

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@andy191x andy191x marked this pull request as ready for review October 30, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant