Prevent NM from handling DNS when network interfaces have DNS config #5846
+180
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ani-sinha
force-pushed
the
fix-nm-dns-conf
branch
from
a76cf20
to
8c578a1
Compare
In the change under PR canonical#5401, we use global DNS configuration as well as DNS and search domain information from interface config and use it to populate /etc/resolv.conf. Therefore, if either or both global DNS/search domain config is present along with per-interface DNS/search domain information, we should add a network manager configuration to prevent network manager from manipulating /etc/resolv.conf. This is in addition to what we already do when only global DNS data is configured. Fixes: 1b8030e ("feat(sysconfig): Add DNS from interface config to resolv.conf (canonical#5401)) Signed-off-by: Ani Sinha <[email protected]>
ani-sinha
force-pushed
the
fix-nm-dns-conf
branch
from
8c578a1
to
8eb2e8d
Compare
ani-sinha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Merge type