-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ec2): Check if IMDS url is IPv6 before enabling ephemeral ipv6 #5826
base: main
Are you sure you want to change the base?
Conversation
cloud-init log |
Thank you for contributing this code and for providing a log for further context! Would you mind cleaning up the proposed commit message to be wrapped at <72 chars wide, have proper punctuation and to remove any mention of the attaching of the log file to the PR? Here is my suggestion for the proposed commit message:
|
Thank you for your reply, commit updated @a-dubs |
Awesome, thank you! @jinkkkang |
@jinkkkang Thanks for this contribution! I think that this would break if a metadata url is provided that is a domain name which points to an IPv6 address. I don't think that this is the case with Ec2, but given the many lookalikes it is hard to tell in advance who this could break. |
alibaba_cloud_without_dhclient_cloud-init.log alibaba_cloud_without_dhclient_with_this_commit_cloud-init.log aws_ec2_without_dhclient_cloud-init.log The original problem was that on Alibaba Cloud, when the dhclient was not installed, The ideal solution is to check the real access address to see if IPv6 url is accessible to determine this parameter, but this will cause the action of accessing meta data to be advanced. Therefore, I think it is sufficient to only determine whether the URL address is IPv6 to determine this parameter |
Please help me review again and let me know if there are any better optimization suggestions @holmanb |
@holmanb @TheRealFalcon hello, Please help merge if there are no issues |
Proposed Commit Message
Additional Context
Test Steps
Merge type