Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: verify_clean_boot enhancements #5801

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

test: verify_clean_boot enhancements

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

# On GH actions, integrations tests run on LXD without quilt
# patches
rc = 2
rc = 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a reasonable assumption now?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that 0f77b3c landed moving us to oracular which is RC = 2 this should be reasonable and no need to check GITHUB_ACTION.

# On GH actions, integrations tests run on LXD without quilt
# patches
rc = 2
rc = 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that 0f77b3c landed moving us to oracular which is RC = 2 this should be reasonable and no need to check GITHUB_ACTION.

@holmanb
Copy link
Member

holmanb commented Oct 8, 2024

        # Look at the commit history before making changes here.
        # Behavior on Jenkins, GH CI, and local runs must be considered
        # for all series.

XD

Yeah, fair enough.

@holmanb
Copy link
Member

holmanb commented Oct 8, 2024

I think that we need to set CLOUD_INIT_OS_IMAGE=oracular so that we actually launch oracular
images.

@blackboxsw blackboxsw merged commit 760ded9 into canonical:main Oct 9, 2024
21 checks passed
@TheRealFalcon TheRealFalcon deleted the verify-clean branch October 9, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants