Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CloudCIX to the data source list. #5779

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

jgrassler
Copy link

Proposed Commit Message

feat(packaging): Add CloudCIX to data source list

This commit adds the recently merged CloudCIX data source to the data
sources in the Ubuntu package.

Additional Context

#1351

Test Steps

  1. Build cloud-init package with this change in place.
  2. Install package with default configuration.
  3. Check if CloudCIX is present in the list of data sources in /etc/cloud/cloud.cfg.d/90_dpkg.cfg.

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@github-actions github-actions bot added the packaging Supplemental package review requested label Oct 3, 2024
@blackboxsw blackboxsw self-assigned this Oct 3, 2024
Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission @jgrassler, I can confirm this is sufficient to include CloudCIX in default datasource settings once we next release the ubuntu/devel branch, Thanks for the debconfig-updatepo artifact too. Can you please add a second commit that adds a lines to the topmost UNRELEASED debian/changelog that contains:

  * d/po/templates.pot and cloud-init.templates: enable CloudCIX by default.

@jgrassler
Copy link
Author

Can you please add a second commit that adds a lines to the topmost UNRELEASED debian/changelog that contains:

Sure. Added.

@blackboxsw blackboxsw added this to the cloud-init-24.4 milestone Oct 3, 2024
@blackboxsw blackboxsw merged commit 06297e5 into canonical:ubuntu/devel Oct 3, 2024
3 checks passed
@blackboxsw
Copy link
Collaborator

blackboxsw commented Oct 3, 2024

Many thanks Approved and merged! This will be in cloud-init 24.4 released to Ubuntu P-series in about 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Supplemental package review requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants