Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nm bridges #5740

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix nm bridges #5740

merged 1 commit into from
Oct 11, 2024

Conversation

TheRealFalcon
Copy link
Member

In draft state until #5674 merges.

Proposed Commit Message

fix: Render v2 bridges correctly on network-manager with set-name

Similar to the recent sysconfig fix, ensure bridges render correctly
for configs that contain `set-name`.

Fixes GH-5717

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@TheRealFalcon
Copy link
Member Author

FYI @xiachen-rh . I am less familiar with network manager keyfile definition, so please let me know if this works for you.

@xiachen-rh
Copy link
Contributor

FYI @xiachen-rh . I am less familiar with network manager keyfile definition, so please let me know if this works for you.

OK, I will test it and let you know the result.

@xiachen-rh
Copy link
Contributor

@TheRealFalcon It works when using NM, thanks!

Copy link

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label Oct 11, 2024
@TheRealFalcon TheRealFalcon removed the stale-pr Pull request is stale; will be auto-closed soon label Oct 11, 2024
Similar to the recent sysconfig fix, ensure bridges render correctly
for configs that contain `set-name`.

Fixes canonicalGH-5717
@TheRealFalcon TheRealFalcon marked this pull request as ready for review October 11, 2024 12:53
@TheRealFalcon
Copy link
Member Author

Rebased and ready for review

Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheRealFalcon, this look good to me!

@TheRealFalcon TheRealFalcon merged commit 9554338 into canonical:main Oct 11, 2024
21 checks passed
@TheRealFalcon TheRealFalcon deleted the fix-nm-bridges branch October 11, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants