-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nm bridges #5740
Fix nm bridges #5740
Conversation
FYI @xiachen-rh . I am less familiar with network manager keyfile definition, so please let me know if this works for you. |
OK, I will test it and let you know the result. |
@TheRealFalcon It works when using NM, thanks! |
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
Similar to the recent sysconfig fix, ensure bridges render correctly for configs that contain `set-name`. Fixes canonicalGH-5717
75e95ff
to
ec24704
Compare
Rebased and ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TheRealFalcon, this look good to me!
In draft state until #5674 merges.
Proposed Commit Message
Additional Context
Test Steps
Merge type