Ubuntu/jammy: fix dailies #5712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patches: debian/patches/no-nocloud-network.patch debian/patches/no-single-process.patch debian/patches/revert-551f560d-cloud-config-after-snap-seeding.patch
TheRealFalcon
commented
Sep 17, 2024
| subp.call_args_list, | ||
| ) | ||
|
|
||
| - if backend == "lvm": |
There was a problem hiding this comment.
This is... confusing. The original test checks to make sure that the semaphore exists when waiting for snap. But on jammy, I'm not sure why we are still testing for this call. Am I missing something?
There was a problem hiding this comment.
we were testing the dm-thin-pool.ko that was just removed, so I removed that as well.
There was a problem hiding this comment.
we were testing the
dm-thin-pool.kothat was just removed, so I removed that as well.
I know, I'm commenting on the remaining test. I don't think that it tests anything valuable, but I guess it doesn't hurt anything either.
TheRealFalcon
commented
Sep 17, 2024
| {% if variant in ["almalinux", "cloudlinux", "rhel"] %} | ||
| # Restart NetworkManager if it is present and running. | ||
| ExecStartPost=/bin/sh -c 'u=NetworkManager.service; \ | ||
| TasksMax=infinity |
|
It looks like I broke the GH Actions quilt job, here is a fix. That test passes manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@holmanb , do you mind reviewing this one? There were two conflicts based on some of your recent changes and I want to make sure I didn't mess them up.
I made an accidental bad push to upstream jammy, so it is currently at tip of main even though it was originally further back.