-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu/jammy: fix dailies #5712
Ubuntu/jammy: fix dailies #5712
Conversation
patches: debian/patches/no-nocloud-network.patch debian/patches/no-single-process.patch debian/patches/revert-551f560d-cloud-config-after-snap-seeding.patch
subp.call_args_list, | ||
) | ||
|
||
- if backend == "lvm": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is... confusing. The original test checks to make sure that the semaphore exists when waiting for snap. But on jammy, I'm not sure why we are still testing for this call. Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we were testing the dm-thin-pool.ko
that was just removed, so I removed that as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we were testing the
dm-thin-pool.ko
that was just removed, so I removed that as well.
I know, I'm commenting on the remaining test. I don't think that it tests anything valuable, but I guess it doesn't hurt anything either.
{% if variant in ["almalinux", "cloudlinux", "rhel"] %} | ||
# Restart NetworkManager if it is present and running. | ||
ExecStartPost=/bin/sh -c 'u=NetworkManager.service; \ | ||
TasksMax=infinity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
It looks like I broke the GH Actions quilt job, here is a fix. That test passes manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@holmanb , do you mind reviewing this one? There were two conflicts based on some of your recent changes and I want to make sure I didn't mess them up.
I made an accidental bad push to upstream jammy, so it is currently at tip of main even though it was originally further back.