-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ec2): Bump url_max_timeout to 240s from 120s. #5565
Conversation
Looks like I missed a doc update in |
@halfdime-code hey can you please provide logs for the failure you were seeing? |
No problem.
|
Thanks @halfdime-code since this is difficult to reproduce, could you please include the rest of |
Please note that this is not a bug in cloud-init, just a behavioral change in AWS afaict. I'm assuming that you want the log up until the failure. Everything after is just cloud-init carrying on as usual. I'm reasonably confident that you won't be able to reproduce it without simply disabling IMDS on an instance and seeing that the timeout occurs. Essentially, this is a timing issue with IMDS availability. If I look at another host that has a "near miss" the logs that I sent you look like this instead. Note the missing "
The logs from start until
|
That should work. Thanks for the response! I'll dig into this soon. |
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
Bumping and tagging @TheRealFalcon as requested. @holmanb was looking into this. |
Hi, @halfdime-code, thanks for submitting this PR and making cloud-init better. I have removed the stale label and the team will have another look on this. Thanks and sorry for the delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@halfdime-code This should be fine, but it looks like this needs to be rebased on main to fix the failing test.
Not 100% sure I got the rebase right here. Please advise if I've gummed up the works. |
Looks like it, but I'll fix it |
Initialization of IMDS is periodically exceeding the 120s limit on instance launch. Increase the timeout to allow for this variance. Update docs to reflect change.
Proposed Commit Message
Additional Context
Test Steps
This issue was seen during instance launch testing and is inconsistent and difficult to reproduce.
Most of the time, the current timeout is not reached.
tox -e py3
was run before and after this change with only hash naming differences.Merge type