Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix no ds cache tests #5529

Merged
merged 2 commits into from
Jul 22, 2024
Merged

test: fix no ds cache tests #5529

merged 2 commits into from
Jul 22, 2024

Conversation

aciba90
Copy link
Contributor

@aciba90 aciba90 commented Jul 22, 2024 •
edited
Loading

Proposed Commit Message

See individual commits

Additional Context

7703634
https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-jammy-lxd_container/470/
https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-focal-lxd_vm/469/

Test Steps

CLOUD_INIT_PLATFORM=lxd_container tox -e integration-tests -- \
  tests/integration_tests/datasources/test_caching.py::test_no_cache_network_only \
  tests/integration_tests/datasources/test_caching.py::test_no_cache_with_fallback

CLOUD_INIT_PLATFORM=lxd_vm CLOUD_INIT_OS_IMAGE=focal tox -e integration-tests -- tests/integration_tests/test_kernel_command_line_match.py::test_lxd_datasource_kernel_override

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@aciba90
test: fix no ds cache tests (canonical#5529)
49edfe5 
After 7703634 log messages migrated
from:

"Detected platform DataSource..." to "Detected DataSource..."

Adapt integration tests accordingly.
aciba90 added a commit to aciba90/cloud-init that referenced this pull request Jul 22, 2024
@aciba90
test: fix test_kernel_command_line_match (canonical#5529)
d9fc336 
Adapt to conform with 7703634
TheRealFalcon
TheRealFalcon approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aciba90 aciba90 merged commit f90f0b8 into canonical:main Jul 22, 2024
23 checks passed
aciba90 added a commit that referenced this pull request Jul 22, 2024
@aciba90
test: fix no ds cache tests (#5529)
2d23852 
After 7703634 log messages migrated
from:

"Detected platform DataSource..." to "Detected DataSource..."

Adapt integration tests accordingly.
@aciba90 aciba90 deleted the fix-no-cache-int-tests branch July 22, 2024 15:15
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Aug 2, 2024
@aciba90 @holmanb
test: fix no ds cache tests (canonical#5529)
29a91f6 
After 7703634 log messages migrated
from:

"Detected platform DataSource..." to "Detected DataSource..."

Adapt integration tests accordingly.
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Aug 2, 2024
@aciba90 @holmanb
test: fix test_kernel_command_line_match (canonical#5529)
5afce4e 
Adapt to conform with 7703634
holmanb pushed a commit that referenced this pull request Aug 6, 2024
@aciba90 @holmanb
test: fix no ds cache tests (#5529)
e1037be 
After 7703634 log messages migrated
from:

"Detected platform DataSource..." to "Detected DataSource..."

Adapt integration tests accordingly.
holmanb pushed a commit that referenced this pull request Aug 6, 2024
@aciba90 @holmanb
test: fix test_kernel_command_line_match (#5529)
3051ce9 
Adapt to conform with 7703634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aciba90 @TheRealFalcon