Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(postinst): Delete unnecessary postinst code #5487

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Jul 3, 2024

Proposed Commit Message

chore(postinst): Delete unnecessary postinst code

Additional Context

  1. Delete version gated code
  • most recent version gate was 22.1-14-g2e17a0d6-0ubuntu1~22.04.5
  • If someone somehow upgraded a Jammy instance to noble without getting the newer Jammy cloud-init package available in jammy-updates, the fix in the postinst would still run since this code exists in all releases of noble.
  1. Delete old preseed code. Debian doesn't use our postinst, and we don't use preseed, so just drop it -> we can probably do this with the maas preseed code too but that requires more investigation

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some inline comments.

If we're confident there's no way we can install with preseed anymore, than I'm not sure why we can't also delete the MAAS preseed code.

debian/cloud-init.postinst Show resolved Hide resolved
debian/cloud-init.postinst Show resolved Hide resolved
@TheRealFalcon TheRealFalcon self-assigned this Jul 5, 2024
@holmanb
Copy link
Member Author

holmanb commented Jul 18, 2024

If we're confident there's no way we can install with preseed anymore, than I'm not sure why we can't also delete the MAAS preseed code.

+1 agreed

@TheRealFalcon I think that I've addressed all of your comments.

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more inline.

debian/cloud-init.postinst Show resolved Hide resolved
debian/cloud-init.postinst Show resolved Hide resolved
@TheRealFalcon
Copy link
Member

@holmanb , just because it is showing up under the resolved comments, I wanted to make sure you can see my latest comment: #5487 (comment)

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@holmanb holmanb merged commit cf13fd1 into canonical:ubuntu/devel Jul 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants