Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ManualSessionSmokeScenario #2095

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Oct 29, 2024

Goal

Fix the ManualSessionSmokeScenario end to end test.

Changeset

Moved the test scenario onto a background thread to avoid ANRs

Testing

Relied on the test passing again on CI

@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1854.87 1674.71
arm64_v8a 631.04 450.82
armeabi_v7a 569.61 385.29
x86 708.85 528.62
x86_64 680.18 495.86

Generated by 🚫 Danger

Copy link
Contributor

@YYChen01988 YYChen01988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI - thanks!

@lemnik lemnik merged commit 6488ddc into next Oct 29, 2024
55 checks passed
@lemnik lemnik deleted the lemnik/ManualSessionSmokeScenario-fix branch October 29, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants