Don't redactKeys in OpaqueValues #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
lemnik
force-pushed
the
lemnik/no-opaquevalue-redacted-keys
branch
from
d0d1e8a
to
1fc88a6
Compare
…st encoded strings are longer than the default 16 characters
lemnik
force-pushed
the
lemnik/no-opaquevalue-redacted-keys
branch
12 times, most recently
from
83321d3
to
04d4df5
Compare
lemnik
force-pushed
the
lemnik/no-opaquevalue-redacted-keys
branch
3 times, most recently
from
04dc943
to
9159186
Compare
… ticket to migrate them
lemnik
force-pushed
the
lemnik/no-opaquevalue-redacted-keys
branch
from
9159186
to
3bf0721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Avoid redacting keys in the OpaqueValue class. The encoding used does not obey the configured set of redacted keys, and this behavior leads to some metadata being redacted in NDK crashes, while some is not.
Testing
Relied on existing tests.