NDK should obey Configuration.maxBreadcrumbs #2020
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
NDK should obey
Configuration.maxBreadcrumbs
Design
Change the
bugsnag_event.breadcrumbs
to be dynamically allocated instead of a fixed-size block. This blob is written out to the event file after the core event, but before the feature-flags.Changes
bugsnag_event.max_crumb_count
to track the size of thebreadcrumbs
bufferbugsnag_event.breadcrumbs
to bebugsnag_breadcrumb*
instead of `bugsnag_breadcrumb[50]Testing
Manual testing, and a new end-to-end test added