feat(session) Make isPaused private

bugsnag · Apr 16, 2024 · ffb7446 · ffb7446
1 parent a96b03a
commit ffb7446
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/bugsnag-android-core/src/main/java/com/bugsnag/android/Session.java b/bugsnag-android-core/src/main/java/com/bugsnag/android/Session.java
@@ -32,7 +32,7 @@ public final class Session implements JsonStream.Streamable, UserAware {
     private final AtomicInteger unhandledCount = new AtomicInteger();
     private final AtomicInteger handledCount = new AtomicInteger();
     private final AtomicBoolean tracked = new AtomicBoolean(false);
-    final AtomicBoolean isPaused = new AtomicBoolean(false);
+    private final AtomicBoolean isPaused = new AtomicBoolean(false);
 
     private String apiKey;
 
@@ -202,10 +202,18 @@ boolean markTracked() {
         return tracked.compareAndSet(false, true);
     }
 
-    boolean markPaused() {
+    boolean markResumed() {
         return isPaused.compareAndSet(true, false);
     }
 
+    void markPaused() {
+        isPaused.set(true);
+    }
+
+    boolean isPaused() {
+        return isPaused.get();
+    }
+
     boolean isAutoCaptured() {
         return autoCaptured;
     }

diff --git a/bugsnag-android-core/src/main/java/com/bugsnag/android/SessionTracker.java b/bugsnag-android-core/src/main/java/com/bugsnag/android/SessionTracker.java
@@ -120,7 +120,7 @@ void pauseSession() {
         Session session = currentSession;
 
         if (session != null) {
-            session.isPaused.set(true);
+            session.markPaused();
             updateState(StateEvent.PauseSession.INSTANCE);
         }
     }
@@ -133,7 +133,7 @@ boolean resumeSession() {
             session = startSession(false);
             resumed = false;
         } else {
-            resumed = session.markPaused();
+            resumed = session.markResumed();
         }
 
         if (session != null) {
@@ -205,7 +205,7 @@ private boolean trackSessionIfNeeded(final Session session) {
     Session getCurrentSession() {
         Session session = currentSession;
 
-        if (session != null && !session.isPaused.get()) {
+        if (session != null && !session.isPaused()) {
             return session;
         }
         return null;

diff --git a/bugsnag-android-core/src/test/java/com/bugsnag/android/SessionTest.kt b/bugsnag-android-core/src/test/java/com/bugsnag/android/SessionTest.kt
@@ -142,6 +142,8 @@ class SessionTest {
             assertEquals(getUser(), copy.getUser()) // make a shallow copy
             assertEquals(isAutoCaptured, copy.isAutoCaptured)
             assertEquals(markTracked(), copy.markTracked())
+            assertEquals(markResumed(), copy.markResumed())
+            assertEquals(isPaused, copy.isPaused)
             assertEquals(markPaused(), copy.markPaused())
             assertEquals(session.unhandledCount, copy.unhandledCount)
             assertEquals(session.handledCount, copy.handledCount)