Add commit hash/version in footer

[fstachura]

No description provided.

[tleb]

I am not convinced this is useful. I'd vote for always returning the standard repo link and trust people can navigate to find the repo version / hash being displayed on the page.

[fstachura]

I think this is useful, and when I see a commit hash, I would expect to be redirected to a particular commit. The link to a particular version can be separate if you think this helps.

[fstachura]

The only problem is that the linked version may not exist in the upstream repo if someone hosts their own. But maybe this is actually good, it signifies that it's a custom instance

[tleb]

If return code is non-zero but nothing is emitted to stderr, we get no error log and return the default "v2.2" silently.

[fstachura]

run_cmd logs errors

[tleb]

No: run_cmd() logs only when something is emitted to stderr. Something can fail (return_code != 0) but not emit anything on stderr.

I think get_elixir_version_string() should be more like (this is a proof-of-concept, not tested):

def get_elixir_version_string():
    version = os.environ.get('ELIXIR_VERSION')
    if version is not None and len(version) != 0:
        return version

    try:
        # try to get Elixir version from git
        result, return_code = run_cmd('git',
            '-C', ELIXIR_DIR,
            '-c', f'safe.directory={ os.path.normpath(ELIXIR_DIR) }',
            'rev-parse', '--short', 'HEAD'
        )

        if return_code != 0:
            raise ValueError(f"git rev-parse returned {return_code}")

        return result.decode('utf-8')
    except Exception as e:
        logging.exception(f"failed to get elixir commit hash: {e}")

    return ''

Edit: or it could be run_cmd() that is modified to log whenever p.returncode is non-zero.