Chad #19

blackboxsw · 2024-03-26T19:25:01Z

Proposed Commit Message

summary: no more than 70 characters

A description of what the change being made is and why it is being
made, if the summary line is insufficient.  The blank line above is
required. This should be wrapped at 72 characters, but otherwise has
no particular length requirements.

If you need to write multiple paragraphs, feel free.

Fixes: #NNNNN (GitHub Issue number. Remove line if irrelevant)
LP: #NNNNNN (Launchpad bug number. Remove line if irrelevant)

Additional Context

Test Steps

Checklist:

My code follows the process laid out in the documentation
I have updated or added any unit tests accordingly
I have updated or added any documentation accordingly

verify_clean_log assumed shadowed warning messages to be contained in a single line entry with a `[WARNING]`, but warnings can be multiline as: ``` 2024-02-16 15:01:49,354 - activators.py[WARNING]: Running ['netplan', 'apply'] resulted in stderr output: Cannot call Open vSwitch: ovsdb-server.service is not running. Failed to connect system bus: No such file or directory Falling back to a hard restart of systemd-networkd.service ``` wrongly asserting the number of expected_warnings. Make this check more reliable by asserting that the number of lines containing `WARNINGS` is less or equal than the number of appearances of the shadowed warning messages.

Create generalized ubuntu_pro.properties definition to be shared in the ubuntu_pro and ubuntu_advantage property schemas as they are identical schema definitions. Given that ubuntu_advantage is now deprecated, add the schema keys deprecated, deprecated_version and deprecated description to provide descriptive warning logs when deprecated keys are present in user-data.

Update cc_ubuntu_advantage module, comments, logs and examples to prefer ubuntu_pro key over ubuntu_advantage to align with the updated product naming. - Deprecate ubuntu_advantage key and represent ubuntu_pro is prioritized - Update product URL to ubuntu.com/pro instead of /advantage - Update log messaging and examples to reference Ubuntu Pro instead of Ubuntu Advantage - Add logic to error when both ubuntu_advantage and ubuntu-advantage keys are present in userdata.

Move the cc_ubuntu_advantage module to cc_ubuntu_pro, updating schema definitions to align with new module name and default /etc/cloud/cloud.cfg to represent ubuntu_pro instead of ubuntu_advantage module.

Also update stale /etc/cloud/cloud.cfg example adding new config modules present in tip of tree.

Reverts 4dbb08f to not change behavior on stable releases.

Avoids LP: #1946003 on upgraded systems. References: [0] canonical#4799 [1] canonical@b519d86 Co-authored-by: Chad Smith <[email protected]>

…#4906) The files in the sysvinit/gentoo directory are OpenRC files not specific to Gentoo and are used by other distro (i.e. Alpine).

On focal we detect NoCloud rather than LXD, so ensure the test reflects this.

Saw "cat: /before-local.start-nostatusjson: No such file or directory" failures. After this change, I no longer see these failures.

…onical#4876) Unlike the majority of other Linux distros /dev/mapper entries in Alpine Linux are NOT symlinks to /dev/dm-X block devices but rather are actual block devices themselves. This is a side-effect of Alpine's use of mdev, rather than udev, in its initramfs. Therefore this change works out the corresponding /dev/dm-X for any /dev/mapper/XYZ device on Alpine.

isc-dhcp-client is no longer supported by upstream BREAKING CHANGE: dhcpcd has been promoted to the default dhcp client. Previous behavior can be configured in cloud.cfg via the dhcp_client_priority key.

cc_apk_configure uses temp_utils.py, which has special logic to return if the user is root that can't be retargeted using our current fixtures. Fix it by setting that tmpdir in the test setup.

On Ubuntu Noble dhcpcd-base is a hard package Depends and also not included by default in ubuntu-minimal images until cloud-init the new cloud-init images contain latest cloud-init. When provided with a DEB_PATH source, use apt instead of dpkg -i to any missing install package dependencies. Fixes: canonicalGH-4908

@blackboxsw

As suggested by @blackboxsw in canonical#4772

A new datasource is implemented for the WSL platform. It relies on being able to access the Windows filesystem and execute cmd.exe to determine where the user data configuration files are. Reference documentation for that datasource is also added, explaining where the user should place the config files, the requirements for the datasource to work and some details that are expected to work differently or not at all. I'm not sure that list is exhaustive, so we should expect revisions to it in the short future. For now at least the implementation is focused on locating and ingesting user-data, without being too smart. Closes UDENG-1989