first stab at integrated prior; works somewhat #1075
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge yet
The idea
Place a proper prior on the (constant) population size
Ne
and then integrate it out of the coalescent likelihood.(i) Employing an inverse-Gamma prior on
Ne
, with parametersalpha
andbeta
one gets a nice closed-form density. This is clumsily implemented insrc/dr/evomodel/coalescent/IGCoalescentLikelihood.java
.(ii) Later, one can integrate over
beta
from0
tou
to potentially get a prior that does not need user input. This has not yet been implemented.Tests
Tests compare the results of using the integrated prior with
alpha = 2.0
andbeta = 10.0
- giving a prior expectation ofE[Ne] = 10
- and the same prior onNe
but sampling its distribution using a standardScaleOperator
(full).All tests were run with
beast -seed 666 -overwrite
for 10M iterations, sampling every 100. Only one replicate was run.Results are shown for tree height and tree length (sum of branch lenghts).
note: Root height should be
2*10*(4/5) = 16.
note: root height should be round about
2*10*49/50 = 19.6
Notes detailing the calculations are available upon request.
all_xmls.zip