Skip to content

Commit

Permalink
Merge pull request practo#155 from practo/remove-dockerhub
Browse files Browse the repository at this point in the history
Remove Dockerhub and use only Public ECR
  • Loading branch information
kishore-practo authored Jul 21, 2023
2 parents de19c77 + f9e36f2 commit 55e14ac
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ script:
- make build
- test -f bin/linux_amd64/workerpodautoscaler
- make all-container
- docker images | grep "^practodev/workerpodautoscaler"
- docker images | grep "^public.ecr.aws/practo/workerpodautoscaler"
- make test
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ BIN := workerpodautoscaler
UNIQUE:=$(shell date +%s)

# Where to push the docker image.
REGISTRY ?= practodev
REGISTRY ?= public.ecr.aws/practo

BASE_BRANCH := master
CURRENT_BRANCH := $(shell git rev-parse --abbrev-ref HEAD)
Expand Down Expand Up @@ -61,7 +61,7 @@ define \n
endef

BUILD_IMAGE ?= golang:1.17.1-alpine
TEST_IMAGE ?= practodev/golang:1.17.1-alpine-test
TEST_IMAGE ?= public.ecr.aws/practo/golang:1.17.1-alpine-test

# If you want to build all binaries, see the 'all-build' rule.
# If you want to build all containers, see the 'all-container' rule.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ git pull origin master

```
- Build and push the image to `hub.docker.com/practodev` or `public.ecr.aws/practo`. Note: dokcerhub or ECR push access is required or use a custom registry by adding `REGISTRY=public.ecr.aws/exampleorg make push`
- Build and push the image to `public.ecr.aws/practo`. Note: ECR push access is required or use a custom registry by adding `REGISTRY=public.ecr.aws/exampleorg make push`
```
git fetch --tags
git tag v1.6.0
Expand Down
2 changes: 1 addition & 1 deletion UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ None
- [v1.5.0](https://github.com/practo/k8s-worker-pod-autoscaler/releases/tag/v1.5.0)

## Upgrade from v1.3 to v1.4
Updates all the kubernetes dependencies with `v1.20`. It should work for the cluster with older versions as well. Also with this release images are available in prato's public ECR as `public.ecr.aws/practo/workerpodautoscaler:v1.3.0`. Default is still practodev.
Updates all the kubernetes dependencies with `v1.20`. It should work for the cluster with older versions as well. Also with this release images are available in practo's public ECR as `public.ecr.aws/practo/workerpodautoscaler:v1.3.0`.

### Breaking changes
None
Expand Down
2 changes: 1 addition & 1 deletion artifacts/deployment-template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ spec:
value: {{ WPA_AWS_ACCESS_KEY_ID }}
- name: AWS_SECRET_ACCESS_KEY
value: {{ WPA_AWS_SECRET_ACCESS_KEY }}
image: practodev/workerpodautoscaler:{{ WPA_TAG }}
image: public.ecr.aws/practo/workerpodautoscaler:{{ WPA_TAG }}
imagePullPolicy: Always
command:
- /workerpodautoscaler
Expand Down
4 changes: 2 additions & 2 deletions artifacts/golang/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

Test image used for `make test`.

Current image being used: `practodev/golang:1.17.1-alpine-test`
Current image being used: `public.ecr.aws/practo/golang:1.17.1-alpine-test`

### Why?
It keeps all the test dependencies installed on top of golang package

### Built using
```
cd 1.17.1-alpine-test
docker build -t practodev/golang:1.17.1-alpine-test .
docker build -t public.ecr.aws/practo/golang:1.17.1-alpine-test .
```
2 changes: 1 addition & 1 deletion hack/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export WPA_AWS_REGIONS="${AWS_REGIONS}"
export WPA_AWS_ACCESS_KEY_ID="${AWS_ACCESS_KEY_ID}"
export WPA_AWS_SECRET_ACCESS_KEY="${AWS_SECRET_ACCESS_KEY}"

echo "Image to be used: practodev/${WPA_TAG}"
echo "Image to be used: public.ecr.aws/practo/${WPA_TAG}"

cp -f $template_deployment $new_deployment
./hack/generate.sh ${new_deployment}
Expand Down

0 comments on commit 55e14ac

Please sign in to comment.