Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java21] Fix Migration issues #2201

Merged
merged 8 commits into from
Oct 29, 2024
Merged

[Java21] Fix Migration issues #2201

merged 8 commits into from
Oct 29, 2024

Conversation

warunalakshitha
Copy link
Contributor

Purpose

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • Checked the impact on OpenAPI generation

@warunalakshitha warunalakshitha changed the title Migrate Runtime APIs argument passing to new APIs Fix Java21 Migration issues Oct 24, 2024
@warunalakshitha warunalakshitha changed the title Fix Java21 Migration issues [Java21] Fix Migration issues Oct 24, 2024
ravinperera00
ravinperera00 approved these changes Oct 29, 2024
View reviewed changes
Copy link

@ravinperera00 ravinperera00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the minor typo fix from past codebase

.github/workflows/build-with-bal-test-graalvm.yml Outdated Show resolved Hide resolved
@warunalakshitha warunalakshitha merged commit 30ed05b into ballerina-platform:java21 Oct 29, 2024
5 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravinperera00 ravinperera00 ravinperera00 approved these changes

@daneshk daneshk Awaiting requested review from daneshk daneshk is a code owner

@TharmiganK TharmiganK Awaiting requested review from TharmiganK TharmiganK is a code owner

@lnash94 lnash94 Awaiting requested review from lnash94 lnash94 is a code owner

@shafreenAnfar shafreenAnfar Awaiting requested review from shafreenAnfar shafreenAnfar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@warunalakshitha @ravinperera00