Add BBE for Regexp find operations
#5677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorna2152
requested review from
MaryamZi,
NipunaRanasinghe and
gimantha
as code owners
poorna2152
force-pushed
the
regex_find
branch
from
ba24c01
to
b386863
Compare
| import ballerina/lang.regexp; | ||
|
|
||
| public function main() { | ||
| string logContent = string ` |
There was a problem hiding this comment.
imo, its better to include non matching example as well
There was a problem hiding this comment.
There are other non-matching info and warn logs in this logContent
| } | ||
|
|
||
| function printGroupsWithinLog(regexp:Groups logGroup) { | ||
| // The first element in the `logGroup` is the entire matched string. |
There was a problem hiding this comment.
Similarly wouldn't it be better if we say why any of these values could be nil
There was a problem hiding this comment.
I don't think we should do explicit null checks here, because since there is a match the expected groups should be there. WDYT?
poorna2152
force-pushed
the
regex_find
branch
from
06a0045
to
d88fe10
Compare
MaryamZi
reviewed
Oct 16, 2024
Co-authored-by: Maryam Ziyad <[email protected]>
MaryamZi
reviewed
Oct 21, 2024
|
MaryamZi
approved these changes
Oct 24, 2024
Merged
via the queue into
ballerina-platform:master
with commit Oct 25, 2024
fbe08d7
5 checks passed
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Part of ballerina-platform/ballerina-dev-website#9318