Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.20] Fix "Committer identity unknown" when patching: #8953

Open
wants to merge 3 commits into
base: release-0.20
Choose a base branch
from

Conversation

eks-distro-pr-bot
Copy link
Contributor

This is an automated cherry-pick of #8951

/assign sp1999

git am is failing to apply the theme patch
because amplify doesn't have a git user and email
configured. This configures a user and email so
the git am doesn't fail.

Signed-off-by: Jacob Weinstock <[email protected]>
This will make sure that a patch failure doesnt
fail silently.

Signed-off-by: Jacob Weinstock <[email protected]>
This allows the patch to always apply. This
is needed for CI environments that don't have
git user and email setup. This won't affect
any global git config locally and doesn't affect
the patch either.

Signed-off-by: Jacob Weinstock <[email protected]>
@sp1999
Copy link
Member

sp1999 commented Nov 1, 2024

/ok-to-test
/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added ok-to-test approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-ok-to-test labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants