Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Curated Packages documentation to point to latest version #8892

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

jhaanvi5
Copy link
Member

@jhaanvi5 jhaanvi5 commented Oct 23, 2024

Description of changes:
This PR

  • Updates curated packages documentation to point to the latest version.
  • Updates packages command to use kubectl apply -f packageFileName instead of eksctl anywhere apply package -f packageFileName in the 'Best Practice' section.

Testing:
Tested locally using:

make container-build
make container-serve

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.40%. Comparing base (b29b07b) to head (8da0534).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8892   +/-   ##
=======================================
  Coverage   72.39%   72.40%           
=======================================
  Files         578      578           
  Lines       45373    45373           
=======================================
+ Hits        32850    32853    +3     
+ Misses      10792    10790    -2     
+ Partials     1731     1730    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999 sp1999 added this to the v0.21.0 milestone Oct 23, 2024
@jhaanvi5
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhaanvi5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 920ddea into aws:main Oct 29, 2024
7 of 8 checks passed
@sp1999
Copy link
Member

sp1999 commented Oct 30, 2024

/cherry-pick release-0.21

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8913

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member

sp1999 commented Oct 30, 2024

/cherry-pick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8914

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member

sp1999 commented Oct 30, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: #8892 failed to apply on top of branch "release-0.19":

Applying: Update Curated Packages documentation to point to latest version
.git/rebase-apply/patch:339: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
A	docs/content/en/docs/packages/cert-manager/v1.14.5.md
A	docs/content/en/docs/packages/harbor/v2.10.2.md
A	docs/content/en/docs/packages/metrics-server/v3.12.1.md
M	docs/content/en/docs/packages/packagelist.md
Falling back to patching base and 3-way merge...
Auto-merging docs/content/en/docs/packages/packagelist.md
CONFLICT (content): Merge conflict in docs/content/en/docs/packages/packagelist.md
Auto-merging docs/content/en/docs/packages/metrics-server/v3.8.2.md
CONFLICT (content): Merge conflict in docs/content/en/docs/packages/metrics-server/v3.8.2.md
Auto-merging docs/content/en/docs/packages/harbor/v2.7.1.md
CONFLICT (content): Merge conflict in docs/content/en/docs/packages/harbor/v2.7.1.md
Auto-merging docs/content/en/docs/packages/cert-manager/v1.9.1.md
CONFLICT (content): Merge conflict in docs/content/en/docs/packages/cert-manager/v1.9.1.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update Curated Packages documentation to point to latest version
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member

sp1999 commented Oct 30, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8919

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member

sp1999 commented Oct 30, 2024

Merged #8916 to fix above merge conflict while cherry-picking this to release-0.19 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants