Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup tinkerbell test resources before every test run #8442

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

g-gaston
Copy link
Member

@g-gaston g-gaston commented Jul 2, 2024

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from g-gaston. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eks-distro-bot eks-distro-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 2, 2024
@g-gaston g-gaston force-pushed the cleanup-tinkerbell-pre-tests branch from a8df4a4 to 3b6059f Compare July 2, 2024 20:20
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 73.46%. Comparing base (19ffd41) to head (3e9c9a9).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/executables/govc.go 45.00% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8442      +/-   ##
==========================================
- Coverage   73.48%   73.46%   -0.02%     
==========================================
  Files         578      578              
  Lines       36489    36507      +18     
==========================================
+ Hits        26814    26821       +7     
- Misses       7956     7965       +9     
- Partials     1719     1721       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g-gaston g-gaston force-pushed the cleanup-tinkerbell-pre-tests branch 3 times, most recently from feb8a1b to 8da4ac6 Compare July 2, 2024 22:28
@g-gaston g-gaston force-pushed the cleanup-tinkerbell-pre-tests branch from 8da4ac6 to 3e9c9a9 Compare July 2, 2024 23:55
@eks-distro-bot eks-distro-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants