Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents viewer from using the video seekbar to skip questions when skip disabled #629

Merged
merged 24 commits into from
Mar 3, 2022

Conversation

dalmia
Copy link
Member

@dalmia dalmia commented Feb 17, 2022

Fixes #628

Summary

  • maintaining a variable for the last answered interaction index
  • when the video is seeked, if the skip is disabled and there are interactions pending and the timestamp that is being seeked to is greater than the timestamp of the first unanswered interaction index, the viewer is shown that interaction
  • when the page is reloaded, if the user was at a timestamp > timestamp of the first unanswered interaction index, we show that interaction.
  • if a user clicks on play when on an unanswered question, they are not allowed to move ahead if skip is disabled

Test Plan

  • Test Responsiveness
    • Laptop (1200px)
    • Tablet (760px)
    • Phone (320px)
  • Cross-Browser Testing
    • Chrome
    • Firefox
    • Safari (use BrowserStack)
  • Local Language Support
  • Hygiene and Housekeeping
    • Self-review
    • Comments have been added appropriately
    • Check for bundle size here if adding a package
    • Added relevant details like Labels/Projects/Milestones etc.
    • If adding or removing any environment variable:
      • update docs/ENV.md
      • update Github Workflow files
      • update DockerFile
      • update the secrets for staging and production
  • Testing
    • Wrote tests
    • Tested locally
    • Tested on staging
    • Tested on an actual physical phone
    • Tested on production
  • Lighthouse Checks
    • Images have alt attributes
    • Any <img> tags have width and height specified
    • Any target="_blank" links have rel="noopener"
    • Only SVGs are used as images. If PNGs are used, their size has been optimised.
    • Any SVGs without text have their aria-label attributes set

@dalmia dalmia added this to the v0.7 milestone Feb 17, 2022
@dalmia dalmia added the bug Something isn't working label Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #629 (52c06f6) into master (996aaf3) will decrease coverage by 0.94%.
The diff coverage is 31.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
- Coverage   85.72%   84.77%   -0.95%     
==========================================
  Files          69       69              
  Lines        4384     4452      +68     
  Branches      782      806      +24     
==========================================
+ Hits         3758     3774      +16     
- Misses        602      654      +52     
  Partials       24       24              
Impacted Files Coverage Δ
src/pages/Embeds/Plio.vue 58.02% <31.68%> (-6.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 996aaf3...52c06f6. Read the comment docs.

@dalmia dalmia temporarily deployed to Staging February 17, 2022 10:12 Inactive
@dalmia dalmia temporarily deployed to End-to-End Testing February 17, 2022 10:12 Inactive
@dalmia dalmia deployed to End-to-End Testing February 21, 2022 06:28 Active
@dalmia dalmia temporarily deployed to Staging February 21, 2022 06:28 Inactive
@dalmia dalmia temporarily deployed to Staging February 21, 2022 07:51 Inactive
@dalmia dalmia temporarily deployed to Staging February 21, 2022 08:19 Inactive
@dalmia dalmia temporarily deployed to Staging February 28, 2022 08:42 Inactive
@dalmia dalmia temporarily deployed to Staging February 28, 2022 09:06 Inactive
@dalmia dalmia temporarily deployed to Staging February 28, 2022 09:31 Inactive
src/pages/Embeds/Plio.vue Outdated Show resolved Hide resolved
src/pages/Embeds/Plio.vue Outdated Show resolved Hide resolved
src/pages/Embeds/Plio.vue Outdated Show resolved Hide resolved
src/pages/Embeds/Plio.vue Show resolved Hide resolved
src/pages/Embeds/Plio.vue Show resolved Hide resolved
src/pages/Embeds/Plio.vue Outdated Show resolved Hide resolved
@dalmia dalmia merged commit 04f5b44 into master Mar 3, 2022
@dalmia dalmia deleted the skip-disabled-bug branch March 3, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viewers can use the video seekbar to skip questions when skip disabled
2 participants