Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Activate panes on any click, not just left click #531

Merged
merged 3 commits into from
Nov 12, 2020

Conversation

winstliu
Copy link
Contributor

@winstliu winstliu commented Nov 15, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This allows focus to be transferred to the containing pane when right clicking on a tab. Helpful for atom/tree-view#1205 where if the Tree View was focused and someone tried renaming a tab by right clicking on it, the resulting dialog would be for the focused Tree View entry rather than the tab.

Also:

  • Remove unused right-clicked class. I plan to remove rightClickedItem later as well.
  • Switch from the non-standard event.which to event.button.

Alternate Designs

None.

Benefits

Focus will be transferred correctly.

Possible Drawbacks

I foresee none.

Applicable Issues

Refs atom/tree-view#1205
Refs atom/atom#16192
Refs atom/atom#21616

@darangi darangi force-pushed the wl-activate-pane-on-right-click branch from 19a76b7 to 45244a1 Compare November 6, 2020 13:17
@darangi darangi merged commit 4bde19f into master Nov 12, 2020
@Lippertt
Copy link

Lippertt commented Apr 6, 2022

https://atom.io/packages/search?utf8=%E2%9C%93&q=keyword:momentjs

@Cszabo8441
Copy link

gh pr checkout 531

Copy link

@kingjollie kingjollie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#311
Duplicate of #[]()

@kingjollie
Copy link

#568 #
Duplicate of #`

Copy link

@kirmo9 kirmo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec/event-helpers.coffee

@TRM1C
Copy link

TRM1C commented Sep 30, 2022

atom-amd64.tar.gz

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants