Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Highlight comments in module #246

Merged
merged 1 commit into from
Jan 23, 2021
Merged

Conversation

Eskibear
Copy link
Contributor

Signed-off-by: Yan Zhang [email protected]

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

To enable comments and javadocs in module

Alternate Designs

unknown

Benefits

To fix part of #245

Possible Drawbacks

unknown

Applicable Issues

#245

Copy link
Contributor

@sadikovi sadikovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a few comments, would appreciate it if you could take a look. I can merge the PR afterwards.

spec/java-spec.coffee Outdated Show resolved Hide resolved
spec/java-spec.coffee Outdated Show resolved Hide resolved
grammars/java.cson Show resolved Hide resolved
spec/java-spec.coffee Outdated Show resolved Hide resolved
@sadikovi sadikovi changed the title highlight comments in module Highlight comments in module Jan 21, 2021
@sadikovi sadikovi merged commit 29f977d into atom:master Jan 23, 2021
@sadikovi
Copy link
Contributor

Thank you for fixing it! Merged to master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants