This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Correctly dispose config observer when servers are closed #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damieng
approved these changes
May 25, 2018
|
Thanks! |
|
Thanks for merging. Is there a release planned in the near future? |
|
@damieng Cool, thanks for the info. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, config changes are observed until the package is deactivated.
This results in
Uncaught Error: Connection is disposed.errors if the config is modified after the language server has been terminated, e.g., when closing all opened files.This bug was reported multiple times in the
ide-pythonpackage: atom-community/ide-python#63, atom-community/ide-python#82This PR adds the config observer to the server disposable in order to watch for changes only when the server is running.