-
-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for calibration queries #2288
Open
olyoberdorf
wants to merge
17
commits into
astropy:main
Choose a base branch
from
olyoberdorf:gemini_calibration_search
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
77d8bdf
adding support for calibration queries (the associated calibrations t…
9870ec6
PEP8 fix for whitespace
110b16b
Merge branch 'main' into gemini_calibration_search
45da78c
fix for header parsing for cals
401e684
Merge branch 'main' into gemini_calibration_search
8d8540d
in progress documentation for calibration calls
36099d2
Merge branch 'main' into gemini_calibration_search
fb8d0ed
check for null table value
952fc5d
adding mention in changelog
372603e
adding support for calibration queries (the associated calibrations t…
2537f2c
PEP8 fix for whitespace
05b66ef
fix for header parsing for cals
1fed566
in progress documentation for calibration calls
99d0b89
check for null table value
363a3b4
adding mention in changelog
19f7ccf
Merge branch 'gemini_calibration_search' of github.com:olyoberdorf/as…
23c4f52
reverting version hack
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are the possible rawqueryargs and rawquerykwargs possibilities? We preferably should not have those wildcard type options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The calls are really mapping to a URL search on the Gemini archive website. These consist of an arbitrary set of arguments in the URL path or key=value arguments as well. It's order independent on the website.
In the case of
query_raw
andquery_calibrations_raw
I really prefer this open-ended approach so the API mirrors what the web API is doing. For the_criteria
calls I could drop them. They are just a convenience if you want to use the more well defined functions but still slip in one or two unusual criteria or terms.