Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex in awk #172

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix regex in awk #172

wants to merge 2 commits into from

Conversation

pmysiak
Copy link

@pmysiak pmysiak commented Jul 3, 2024

It should be escaped. On some platform it's interpreting as interval

It should be escaped. On some platform it's interpreting as interval
@pmysiak pmysiak requested a review from a team as a code owner July 3, 2024 14:56
Copy link

@mirandafialho mirandafialho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works

Copy link
Contributor

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one.

bin/list-all Outdated
@@ -10,7 +10,7 @@ sort_versions() {
versions=$(
git ls-remote --tags https://github.com/php/php-src.git |
grep 'php-' |
awk '!/({})/ {print $2}' |
awk '!/(\{\})/ {print $2}' |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfandrade recommended this...

Suggested change
awk '!/(\{\})/ {print $2}' |
awk '!/\{.*\}/ {print $2}' |

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants