Switch component #620
Merged
Switch component #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bpierre
reviewed
Oct 16, 2019
|
Btw @adekbadek, it would be really great to have you sign the CLA (https://github.com/aragon/aragon-ui/pull/620#issuecomment-542311208) :). |
bpierre
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
✔️ ✔️ ✔️
One last thing: I remember a comment from @dizzypaty about the transition being a bit slow? Maybe it has been addressed already, but if not we could try springs.swift to make it faster maybe?
sohkai
reviewed
Oct 16, 2019
src/components/Switch/README.md
Outdated
|
|
||
| ### `onChange` | ||
|
|
||
| - Type: `Function`: `(checked: Boolean) -> *` |
There was a problem hiding this comment.
Nice! We should definitely do this for our other argument props :)
bpierre
pushed a commit
that referenced
this pull request
Nov 18, 2019
Add a Switch component and update theme’s control-related colors.
bpierre
pushed a commit
that referenced
this pull request
Nov 18, 2019
Add a Switch component and update theme’s control-related colors.
bpierre
pushed a commit
that referenced
this pull request
Nov 20, 2019
Add a Switch component and update theme’s control-related colors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/aragon/aragon-ui/issues/596
Adds a
Switchcomponent and updates theme's control-related colors.