Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent: Filtering Updates #1193

Merged
merged 4 commits into from
Jul 14, 2020
Merged

Agent: Filtering Updates #1193

merged 4 commits into from
Jul 14, 2020

Conversation

Evalir
Copy link
Contributor

@Evalir Evalir commented Jul 6, 2020

Addresses the first 3 points of the pending Agent upgrades.

@Evalir Evalir mentioned this pull request Jul 6, 2020
Open
6 tasks
@Evalir Evalir changed the title [WIP] Agent: Filtering Updates Agent: Filtering Updates Jul 9, 2020
@Evalir Evalir requested review from sohkai and bpierre July 9, 2020 13:39
@Evalir Evalir marked this pull request as ready for review July 9, 2020 13:39
@Evalir
Copy link
Contributor Author

Evalir commented Jul 9, 2020

@sohkai @bpierre this is ready for review! Can use some feedback as it turned out to be pretty short. :)

andy-hook
andy-hook approved these changes Jul 13, 2020
View reviewed changes
Copy link

@andy-hook andy-hook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! left a minor comment on whether it's worth passing around the const value for building the labels.

apps/agent/app/src/components/useFilteredTransactions.js Outdated Show resolved Hide resolved
apps/agent/app/src/components/useFilteredTransactions.js Show resolved Hide resolved
apps/agent/app/src/components/Transactions.js Show resolved Hide resolved
@Evalir
Add proper spelling :)
72d6066 
Co-authored-by: Andy Hook <[email protected]>
sohkai
sohkai approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Evalir Evalir merged commit b125492 into master Jul 14, 2020
@Evalir Evalir deleted the agent-filtering-updates branch July 14, 2020 13:23
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
@Evalir
Agent: Filtering Updates (aragon#1193)
09f358f 
* Agent Filtering: Move page reset to 0 to be an effect

* Filtering: make transactionTypes be provided by useFilteredTransactions hook

* Agent: Implement individual date filtering

* Add proper spelling :)

Co-authored-by: Andy Hook <[email protected]>

Co-authored-by: Andy Hook <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai sohkai approved these changes

@andy-hook andy-hook andy-hook approved these changes

@bpierre bpierre Awaiting requested review from bpierre

Assignees
No one assigned
Labels
app: agent component: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Evalir @sohkai @andy-hook