add checkClassName regex func #11303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanck
approved these changes
Oct 16, 2024
|
Thanks for the PR @ryanjclark ! |
bryanck
reviewed
Oct 16, 2024
| @@ -406,6 +406,10 @@ public JsonConverter jsonConverter() { | |||
| return jsonConverter; | |||
| } | |||
|
|
|||
| public static boolean checkClassName(String className) { | |||
There was a problem hiding this comment.
One nit, can you make this private?
bryanck
reviewed
Oct 16, 2024
| @@ -406,6 +406,10 @@ public JsonConverter jsonConverter() { | |||
| return jsonConverter; | |||
| } | |||
|
|
|||
| static boolean checkClassName(String className) { | |||
There was a problem hiding this comment.
One more nit, could you add @VisibleForTesting? That makes it clear why it isn't private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a custom wrapper on the ConnectDistributed class which does not match the regex check here. This PR expands the regex to be more generous but is still reasonable, especially considering the properties check afterwards.
Closes an issue in tabular.io/iceberg-kafka-connect