Support reverting "foreign language only" mode by choosing English #9570
+80
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A safer alternative to #9569 - don't try to infer intention from absence of a checkbox, and instead require user to explicitly switch back to English. Hoping this means fewer changes required in the controller or the Edition:Translatable module. Trello: https://trello.com/c/5B60uybX/3062-unable-to-uncheck-the-create-a-foreign-language-only-box
ChrisBAshton
force-pushed
the
support-reverting-foreign-language-only-mode-by-adding-english-option
branch
from
61058d3
to
4f7c84e
Compare
ChrisBAshton
force-pushed
the
support-reverting-foreign-language-only-mode-by-adding-english-option
branch
from
1ce0a32
to
3ac8c55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A safer alternative to #9569 - don't try to infer intention from absence of a checkbox, and instead require user to explicitly switch back to English.
Hoping this means fewer changes required in the controller or the Edition:Translatable module.
Trello: https://trello.com/c/5B60uybX/3062-unable-to-uncheck-the-create-a-foreign-language-only-box
Follow these steps if you are doing a Rails upgrade.