Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a test to demonstrate encoded path matching #149

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sihugh
Copy link
Contributor

@sihugh sihugh commented Mar 4, 2020

This is a copy / tweak of existing tests and demonstrates that router routes things that are URL encoded.

At least one of our frontend apps is not built to handle URL encoded paths and errors under some circumstances. A sort of fix has been implemented for collections.

Should we "fix" router to not behave like this?

Related stack overflows are seem inconclusive - for example Apache allows you to toggle a setting to allow / disallow this.

@sengi
Copy link
Contributor

sengi commented May 9, 2024

Hmm interesting. Sounds like the current behaviour has potential for request smuggling shenaningans (but I've spent like 30 s thinking about it so not making any claims here!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants