Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Go content #943

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove Go content #943

wants to merge 2 commits into from

Conversation

huwd
Copy link
Member

@huwd huwd commented Oct 8, 2024

One for folks with more GDS history than me to 👀 but as I reviewed around these changes felt right to me.

If you are reading this commit by commit, no fear I add something back
in in the next commit.

Why remove this whole section at this level however?

Go's major reason to be at GDS was tied to PaaS, and PaaS has now
largely gone away.

I think the point the section makes about how there could be a use for
routing etc isn't a bad one, but I think that's far more likely to
happen today deep in the gubbins of AWS, in Infrastructure-as-code or in
languages like sucati for firewall rules.

So my vote here, is that we remove it wholesale. If there are future
ventures that come up with good uses for Go, they should be subject to
the bottom paragraph, raise it with your head of Tech and bring it back
formally with a good usecase.
- Previously this just talked about scala, let's make this it's own
  heading level

- Then let's add a note on Go, resucing some of the good stuff from the
  paragraph I just deleted but very much talking in past tense now.

Hopefully this helps cement the idea that we wouldn't expect Go to be
used as a new language at GDS right now.
@huwd huwd changed the title Adjust go content Remove Go content Oct 8, 2024
@huwd
Copy link
Member Author

huwd commented Oct 8, 2024

Question... does removing it here mean we should remove the styleguides and links?

https://gds-way.digital.cabinet-office.gov.uk/manuals/programming-languages.html
&
https://gds-way.digital.cabinet-office.gov.uk/manuals/programming-languages/go.html

In my head:
Argument for - Clean up, why maintain redundant pages when we don't have to. These pages are unlikely to see much use, should they have a future need they can be resurrected from the git history.

Argument against - It's still used in GOV.UK's Router... so might be useful to see how to refactor / write fixes in good style. Plus there's a good banner at the top saying it's not core, so limited risk someone gets excited and starts using it, better chance they search find this and find out there's a head of tech to speak to?

Foundry](https://www.cloudfoundry.org/), which GOV.UK PaaS uses, although
GOV.UK PaaS is being [decommissioned][pass-decom]. As such, the knowledge and
experience of building and running services in Go is small and decreasing.
Foundry](https://www.cloudfoundry.org/), which was used by GOV.UK PaaS.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to keep the precious copy? Router is still used, right? And CloudFoundry is no-mo, along the paas-decom.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's happened with this commit, but this paragraph makes no sense. I'm assuming this is supposed to say GOV.UK Router, and there's no need to mention PaaS:

the GOV.UK Foundry, which was used by GOV.UK PaaS

The only Go service currently in production operation is the [GOV.UK
Foundry](https://www.cloudfoundry.org/), which was used by GOV.UK PaaS.

PaaS has now been [decommissioned][pass-decom].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PaaS has not yet been completely decommissioned. While it's no longer available for general use, it's still being operated within GDS, and used by DBT.

Copy link
Contributor

@louzoid-gds louzoid-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm mostly minded to leave the guidance on Go as it presently stands as GOV.UK PaaS is still in use and supported. We are also already making it pretty clear that we shouldn't be using it for new things.
Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants