-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDS branding #920
base: main
Are you sure you want to change the base?
GDS branding #920
Conversation
- to make more clear that this is by *and for* GDS - compliance with the Service Manual - we must not use New Transport
Looks nice and clean to me. |
Not using New Transport seems like a very strict interpretation of the Service Manual. While it says your site "must look like GOV.UK if it’s on one of |
@cjfryer the quote from the page I linked is:
:-) |
@galund yes, and that section talks (vaguely) about services that aren't "considered part of GOV.UK." An equally strict interpretation of the rules would prevent GOV.UK One Login from using the Design System, since it's on All academic, I suspect, since the PR is approved 😁 |
@galund I like the GDS logo helps situate this well and perhaps distinguish from something like the service manual. However I'm also not sure about that call on the font, I get that the quote from service manual seems clear... but in practice I'd understood it came down to site intent + if you were on a *.gov.uk domain... 🤔 might ask the senior GDS hive mind there. I do find transport a bit clearer to read, so would like to keep it if we can. |
For use of the Design System, this is a constraint that we have placed on ourselves, that we are free to change. GDS Transport (the actual font name) has a licence agreement that restricts its legal use to a limited number of domains: Edit: Having said that, it's actually not clear in the licence whether there are domain restrictions, and what those restrictions are if not. I've always used that blog post as the canonical position, and I'm now questioning whether it's actually correct... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the logo addition (I think it's a useful addition to the clarity of the scope of the GDS Way), but I think we should park the GDS Transport change.
Actually, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of the page Safari's history is The GDS Way - <span class="gds-logo">GDS</span> The GDS Way
. I don't think a span
can be in a title
block
Re fonts I def feel like arguing about hypocrisy wrt the Service Manual, in the GDS Way of all places :-D ... but it's clear the implementation here is borked so will go away and re-work! |
Branding - add logo and change font
References:
GDS brand guidelines: https://drive.google.com/file/d/1UU0i_cudRpDdf_qRfgCIRB9YYrFkdGVI/view
Service Manual: https://www.gov.uk/service-manual/design/making-your-service-look-like-govuk#if-your-service-isnt-on-govuk