Dynamic popular tasks - by content id #3829
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are turning off our AB test, and adding popular tasks to all mainstream browse pages. This commit adds the tasks as a hard coded list. Future work will allow the tasks to be fetched from SearchAPI
Bumps [gds-api-adapters](https://github.com/alphagov/gds-api-adapters) from 97.0.0 to 97.1.0. - [Changelog](https://github.com/alphagov/gds-api-adapters/blob/main/CHANGELOG.md) - [Commits](alphagov/gds-api-adapters@v97.0.0...v97.1.0) --- updated-dependencies: - dependency-name: gds-api-adapters dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [govspeak](https://github.com/alphagov/govspeak) from 8.5.1 to 8.6.0. - [Changelog](https://github.com/alphagov/govspeak/blob/main/CHANGELOG.md) - [Commits](alphagov/govspeak@v8.5.1...v8.6.0) --- updated-dependencies: - dependency-name: govspeak dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Use a different exception when this situation is detected: * Sanitiser::Strategy::SanitisingError This error is not sent to Sentry. See: alphagov/govuk_app_config#402
See: * https://github.com/whitequark/rack-utf8_sanitizer/blob/b069c9ef6d69e58695ec9a7cad68c41b57812468/lib/rack/utf8_sanitizer.rb#L21 * https://github.com/whitequark/rack-utf8_sanitizer/blob/b069c9ef6d69e58695ec9a7cad68c41b57812468/lib/rack/utf8_sanitizer.rb#L84 * https://github.com/whitequark/rack-utf8_sanitizer/blob/b069c9ef6d69e58695ec9a7cad68c41b57812468/lib/rack/utf8_sanitizer.rb#L121 Collections currently do not have any POST/PATCH/PUT routes for uploading form data, but this is being added for consistency with other repositories and in case such routes will be added in the future.
Following the same patterns set in the existing ListSet model which fetches tagged content for level two browse pages.
hannako
force-pushed
the
dynamic_popular_browse_by_contentid
branch
from
17deda6
to
b0eecaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.